mahara-contributors team mailing list archive

[Mahara Bot <1844953@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10376
Committed: https://git.mahara.org/mahara/mahara/commit/c0889d626edf1af6806a139a980a3774c1f88f3a
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c0889d626edf1af6806a139a980a3774c1f88f3a
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Sep 25 09:17:28 2019 +1200

Bug 1844953: Make the font specimens appear in modal

Rather than a new page

behatnotneeded

Change-Id: If81c1b343b1d32e291ca90e036082009c2d33a4f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1844953

Title:
  Turn font specimen page into a modal

Status in Mahara:
  Fix Committed

Bug description:
  TITLE: Old Mahara logo displayed on Fonts specimen pages

  BUG SUMMARY: Old Mahara logo displayed on Configure site --> Fonts
  'View font specimen' detail page

  ENVIRONMENT: Master
  PATCHSET: git fetch https://reviews.mahara.org/mahara refs/changes/12/10312/8 && git checkout FETCH_HEAD
  BROWSER: Firefox

  PRECONDITION/S: n/a

  TEST STEPS:
  1) Log in using the Mahara Admin user
  2) Navigate to Configure site --> Fonts, 'All fonts' will be displayed (including the Theme fonts)
  3) On one or more of the displayed font rows, select the 'View font specimen' link (second link top right)

  Expected result (updated after comment 2): Show the correct Mahara page element, including header, footer, and heading, no custom Mahara logo.
  Actual result: see attached screen shot - the old Mahara logo is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1844953/+subscriptions