mahara-contributors team mailing list archive

[Mahara Bot <1841988@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10279
Committed: https://git.mahara.org/mahara/mahara/commit/22e4a2dd656f77425645ecc3a357b705678ee825
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 22e4a2dd656f77425645ecc3a357b705678ee825
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 30 08:08:29 2019 +1200

Bug 1841988: Making sure pieform is generated before smarty_core() call

There are a few places where this was not being done in correct order

Also fixed up the add admins / staff pages so that submitting nothing
gives an error

behatnotneeded

Change-Id: Ib60a3a4ffce0e73b38c42badc57cfc6fe6db372c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1841988

Title:
  Tidy up some places where we call pieform() after smarty_core()

Status in Mahara:
  Fix Committed

Bug description:
  If we call pieform() after smarty_core() it generates an error:

  Pieform element XXX wants to add headdata to the page, but it's too
  late. Build your form before generating the page.

  So will tidy up the existing places where this is still the case

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1841988/+subscriptions