mahara-contributors team mailing list archive

[Mahara Bot <1785985@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10280
Committed: https://git.mahara.org/mahara/mahara/commit/8e7a3135a1c866ce6856b95da19f9355d331c0ef
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 8e7a3135a1c866ce6856b95da19f9355d331c0ef
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 30 14:00:16 2019 +1200

Bug 1785985: Remove quota triggers

- This looks like it was being handled by eventlistener_savedeleteartefact
and so didn't need to be a trigger function anyway

behatnotneeded

Change-Id: I837d2f4725c44ff0c525873b3406396033eb408c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1785985

Title:
  Remove triggers from Mahara database

Status in Mahara:
  Fix Committed

Bug description:
  I've created a forum post to discuss this:

  * https://mahara.org/interaction/forum/topic.php?id=8324

  Basically, my reasoning is:

  
  1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain.

  2. Mahara already has the concept of events in place. We can move the
  functionality of each trigger into an event. We would then have more
  control over the event. For example, don't action an event during an
  upgrade.

  3. Triggers make it difficult to see what is actually happening. They
  are not transparent. If you weren't aware that there is a trigger on
  the table, it can make it difficult to track down why something is
  behaving in a certain way.

  
  We can start slowly by removing one at a time. It doesn't have to happen all at once.

  Just my thoughts.

  Cheers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions