mahara-contributors team mailing list archive

[Mahara Bot <1849395@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10477
Committed: https://git.mahara.org/mahara/mahara/commit/49961c80bd209af7b728691b086a6e5b78e6f687
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit 49961c80bd209af7b728691b086a6e5b78e6f687
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Oct 23 12:20:42 2019 +1300

Bug 1849395: Doublecheck details values for modal

Before displaying content

behatnotneeded

Change-Id: Ibdd0b33d543f65cf619fc5a061b6f81350d1d94a
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 9ef9014abf2da8bb4978ad223ec82ca6bad0022b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1849395

Title:
  Need to lock down the view/viewblocks.json.php response more

Status in Mahara:
  In Progress

Bug description:
  Currently it only checks if you can see the page

  But if you give it block/artefact values you shouldn't see you get
  content back

  We need to do the following checks
  1) can user see the page? if so
  2) is the block on the page? if so
  3) can the user see the block content? (a peer might not be able to) if so
  4) is the artefact part of the block?

  Only then can we show the content in the modal

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1849395/+subscriptions