mahara-contributors team mailing list archive

[Mahara Bot <1843513@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10536
Committed: https://git.mahara.org/mahara/mahara/commit/9e0d6435986416f29f0f47d33f3986f36846759f
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit 9e0d6435986416f29f0f47d33f3986f36846759f
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Oct 21 09:51:59 2019 +1300

Bug 1843513: Allow for 'normal' a href links not to change to https

When we save links and then go to display them we convert non https
ones to protocol relative urls if the Mahara site is https

This is to avoid mixed content issues with iframes

But we should not convert static a href links if we don't need to so
have made adjustments to the custom URI filter

behatnotneeded

Change-Id: I87298f2744e03eabee7906f1fdb0c2d0936a9fd5
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit c3677ec52e17ef10d45fb5e9b12d376b8a9eccc9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1843513

Title:
  Links included in text boxes are converted from http to https

Status in Mahara:
  Fix Committed

Bug description:
  https://mahara.org/interaction/forum/topic.php?id=8507&offset=0&limit=10#post33924

  I have not been able to replicate this locally, but it occurs on demo.

  We suspect because the Mahara site is https, the link is being
  converted by HTML Purifier to https to avoid mixed content warnings.

  We need to allow a link to be http rather than https because some
  sites are not using https yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1843513/+subscriptions