← Back to team overview

mahara-contributors team mailing list archive

[Bug 1850712] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10543
Committed: https://git.mahara.org/mahara/mahara/commit/c2d2226e03ca424bc826ddb22aad6e31e1d1e287
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit c2d2226e03ca424bc826ddb22aad6e31e1d1e287
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Oct 31 09:35:01 2019 +1300

Bug 1850712: When copying a group task without an assigned portfolio

When we turn off the switch (set to 'No') there is an error with
trying to fetch the portfolio info

behatnotneeded

Change-Id: Ide34fb96b21de12681a8cff0734f5c14e1d9679c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit d0c90a6d1cc770edf2c9a190668dc0c67635ebdd)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850712

Title:
  Group plans tasks without portfolio assignment cause error when
  turning off for member

Status in Mahara:
  Fix Committed

Bug description:
  When the following is set up:

  1. Database with 1 group plan and 3 tasks: 1 without task page and assignment portfolio, 1 with task page, 1 with assignment portfolio.
  2. Select all three by regular non-editing group member.
  3. Turn off all three again. The first one that doesn't have portfolio produces "Not supported portfolio type" error (below). 

  
  [WAR] 79 (artefact/plans/tools/PlansTools.php:852) get_class() expects parameter 1 to be object, null given
  Call stack (most recent first):

      log_message("get_class() expects parameter 1 to be object, null...", 8, true, true, "/home/kristina/code/mahara/htdocs/artefact/plans/t...", 852) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
      error(2, "get_class() expects parameter 1 to be object, null...", "/home/kristina/code/mahara/htdocs/artefact/plans/t...", 852, array(size 1)) at Unknown:0
      get_class(null) at /home/kristina/code/mahara/htdocs/artefact/plans/tools/PlansTools.php:852
      artefact\plans\tools\PlansTools::createOutcomeUrlForPortfolioElement(null) at /home/kristina/code/mahara/htdocs/artefact/plans/groupplans/toggle_grouptask.json.php:60

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850712/+subscriptions


References