← Back to team overview

mahara-contributors team mailing list archive

[Bug 1850859] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10612
Committed: https://git.mahara.org/mahara/mahara/commit/e89c416d1d651794ae06d233d6343989d1404389
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit e89c416d1d651794ae06d233d6343989d1404389
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Nov 14 13:21:01 2019 +1300

Bug 1850859: consolidate css for skins to work better with new header
details mode

- #viewh1 was targeting page titles of page's using a skin with a
bold font-weight. There were a few places using the #viewh1 but none of them seemed
to actually be in bold.  Have removed it for now to fix page titles.

- Also added the link / link hover styles to the tags / page owner
links so they can be controlled the same way as page links

behatnotneeded

Change-Id: I945584426798aa5835452dc885816c60c377ce34
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit 7b77d3659adeb0b09f7ea3a1683c75d104447fc7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850859

Title:
  Consolidate CSS for skins to work better with new header and details
  mode

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  In bug 1847005 a number of changes were made to get skin colors work
  better with the new header and details mode.

  One thing that is missing is that "by" and "Tags" are also in the same
  colour as the header text.

  The line below a collection title should also be in the heading font
  as it is not visible on dark backgrounds.

  Evonne suggested removing / changing some more CSS so that the new
  styles work better in skins.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850859/+subscriptions


References