mahara-contributors team mailing list archive

[Mahara Bot <1853364@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10626
Committed: https://git.mahara.org/mahara/mahara/commit/66f6fc94745687eed57df82d5f13ce1dfd215260
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit 66f6fc94745687eed57df82d5f13ce1dfd215260
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 21 08:54:44 2019 +1300

Bug 1853364: Only populating the user object if user found

behatnotneeded

Change-Id: Ia1351273cc400a61370381403d968e3f4534ae13
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit ac8f3a5fb00263a17158c7c666f9a28fcc4e8e13)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1853364

Title:
  find_by_instanceid_username can cause error

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  When checking for a user against remote name and no users returned

  error(2, "First parameter must either be an object or the na...", "../auth/user.php", 336, array(size 3)) at Unknown:0
  property_exists(false, "probation") at ../auth/user.php:336
  User->populate(false) at ../auth/user.php:287
  User->find_by_instanceid_username("33", "prova", true) at ../auth/xmlrpc/lib.php:154

  We made some adjustments to the way find_by_instanceid_username()
  works but there is still a bit of logic to sort out

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1853364/+subscriptions