← Back to team overview

mahara-contributors team mailing list archive

[Bug 1843357] Re: Library upgrade: remove jquery deprecations

 

This patch touches a lot of areas of Mahara, which I have tried to test
comprehensively. Here are some notes of what I did and didn't test:

account/index.php
Change your username.
Refresh the page. 
Your new username should appear in the Online users box in brackets next to your name.
There should not be console errors.

htdocs/artefact/resume/lib.php
Go to the Education and Employment page. Add a couple of qualifications. Confirm there are no console errors

Fancybox
Add a block to a page with a gallery of images in it. Clicking on each image should expand it into the middle of the page with the rest of the page shaded out.

Jsoneditor
Check that the copy and edit buttons work as expected and clear on page reload.

Jquery-ui 
Use Gridstack to change the size of boxes and move them around the page. 
Check for console errors.

htdocs/theme/raw/templates/form/userlist.tpl
Check that the page for adding users to an institution populates correctly and that members can be added/invited without errors.

In the following files a variable called $offset was required to be >0 for the changes to run.
Without replicating the circumstances I hard-coded it up and checked the code ran without errors.
Make sure skins are enabled in config.php
Go to http://mahara/admin/site/fonts.php
groupviews.php
Go to http://mahara/admin/site/views.php

htdocs/admin/extensions/plugins.php - not tested. Looks like it requires
install of a new plugin to achieve.

Couldn't test http://mahara/admin/users/statistics.php
could see the statistics table, but not .btn.filter

elasticsearch
focus is the first search element - not tested.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1843357

Title:
  Library upgrade: remove jquery deprecations

Status in Mahara:
  In Progress

Bug description:
  This is related to https://bugs.launchpad.net/mahara/+bug/1840105

  Jquery 3.4.0 deprecated quite a few selectors that we use. However
  there are no warnings and the removal of related code is not scheduled
  until 4.0. For that reason I am creating a new bug as a reminder to
  fix this while I move on with other upgrades.

  Deprecations: https://api.jquery.com/category/deprecated/deprecated-3.4/
  Changelog: https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/
  Basic example: https://forum.jquery.com/topic/jquery-3-4-replacement-examples-for-deprecated-positional-selectors-first-last

  So the idea is to replace the selectors with the jquery methods
  first(), last() and eq(), and/or to use equivalent css selectors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1843357/+subscriptions


References