mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #57021
[Bug 1855373] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10657
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1855373
Title:
Update gulp
Status in Mahara:
In Progress
Bug description:
A while ago we pinned Gulp to version 3.9 to prevent a problem with
dependency incompatibility. We now need to upgrade Gulp to version 4
to get rid of vulnerabilities in some of its dependencies.
What needs to happen:
1. Check for dependency incompatibility with Gulp 4 to see if it's still an issue. If so, can we work around it?
2. See what's involved with upgrading to Gulp 4
3. We could look at the dependencies we are including for gulp (and maybe node dependencies too, although this could be a separate issue) and confirm that they are needed in Mahara.
Investigation of the above points:
1. The only dependency we have now that is incompatible with v.4 seems to be gulp-help. It doesn't look like it will cause any problems to remove it, so we should just remove it.
2. There are syntax changes that need to be made, but it looks like they can be made in the gulpfile.js, which limits the coding to be done.
Assumption made: There are no wider changes necessary.
3. Not looked at at this stage.
Gulp docs:
https://gulpjs.com/docs/en/getting-started/quick-start
3rd party links:
https://stackoverflow.com/questions/36897877/gulp-error-the-following-tasks-did-not-complete-did-you-forget-to-signal-async
https://stackoverflow.com/questions/50505275/gulp4-assertionerror-task-never-defined-when-calling-or-importing-tasks
https://codeburst.io/switching-to-gulp-4-0-271ae63530c0
https://coder-coder.com/gulp-4-walk-through/
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1855373/+subscriptions
References