mahara-contributors team mailing list archive

[Mahara Bot <1840195@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10263
Committed: https://git.mahara.org/mahara/mahara/commit/a6078c4936b2f872d762333f942e2b57cac24a8f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit a6078c4936b2f872d762333f942e2b57cac24a8f
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Thu Aug 15 12:52:40 2019 +1200

Bug 1840195: add function to check if a cron jobs needs to be executed

this adds the possibility to define a check to see if a
cron callfunction needs to be executed before droping
elasticsearch triggers or calling the cron function

if the check function is not define then the cron
call function will be executed as before

to define the check function it has to have the name
of the cron callfunction and add a 'needs_to_run'
at the end

+ also making the successful login reset the logintries
to 0 for the user on the DB

behatnotneeded

Change-Id: I0abe28c1172136da043c9e9310c315b75c7d4fbb

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1840195

Title:
  Add a function to check if a cron callfunction needs to run before
  actually executing it

Status in Mahara:
  Fix Committed

Bug description:
  There are cron functions that run many times a day that don't need to run that often but they need to monitor a condition.
  One of these is for example the user_login_tries_to_zero that resets the logintries value in the usr table to be 0, so the user can try to login again if they failed 5 times. This doesn't need to run if there are no values to reset.

  If we have a way to checks if the cron function needs to run or not,
  and we also work with elastic search, we can check if the triggers
  need to be dropped. This way we're reducing the times we drop and
  recreate elasticsearch triggers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1840195/+subscriptions