mahara-contributors team mailing list archive

[Mahara Bot <1854421@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10630
Committed: https://git.mahara.org/mahara/mahara/commit/7e5f3f60c489ca8db13d989cd0cc94011c8988ba
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 7e5f3f60c489ca8db13d989cd0cc94011c8988ba
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 29 15:52:05 2019 +1300

Bug 1854421: Allow site form to reload page on save

If certain fields are changed, like theme / language.
As we can't 'see' the changes until we reload the page.

We used to have some code to reload the page if theose fields changed
but it go broken over the years. This tries to fix that.

Change-Id: I62b6740bbdd2757752a21a18e3d76fb0cefcf4d6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1854421

Title:
  Get site options  form to reload page on updating certain fields

Status in Mahara:
  Fix Committed

Bug description:
  When we update the language or theme fields it's not obvious that
  things have changed

  We get a saved success message but things still look the same - we
  need to then refresh the page to see the changes.

  This can be a bit confusing.

  We had some code in the past to reload the page if certain field were
  filled in - by making the form submit in a non js way. But this got
  broken and trying to fix that breaks other things.

  So instead I will get it working by applying the reload after the page
  save, with an 'Applying changes' popup to appear for a second before
  the page reloads

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1854421/+subscriptions