← Back to team overview

mahara-contributors team mailing list archive

[Bug 1857274] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10698
Committed: https://git.mahara.org/mahara/mahara/commit/b6d446de29ac854a51a65fb04b8d9dbd922c82b0
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit b6d446de29ac854a51a65fb04b8d9dbd922c82b0
Author: Evonne Cheung <evonne@xxxxxxxxxxxxxxx>
Date:   Wed Jan 8 13:38:42 2020 +1300

Bug 1857274: Removed highlight from "Display page" button

It was highlighted in "Edit" mode, which was
confusing as the display action was not active
since you were in "Edit" mode.

Change-Id: I1ff630eec4e512e466261b10c419d1f52fd2471d
behatnotneeded: style change only

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857274

Title:
  "Display page" button is highlighted in edit mode when it shouldn't be

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  Mahara 19.10+

  The "Display page" button is highlighted when in edit mode, which
  indicates that the display mode is turned on when that is actually not
  the case. That is a left-over from the "Edit mode" button that we had
  before.

  To replicate:

  1. Create a page.
  2. Go into edit mode.
  Expected result: None of the grey buttons on the right-hand side are highlighted (the "Add" button is in the primary brand color and stands out correctly).
  Actual result: The "Display page" button has a darker grey indicating that it is active.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857274/+subscriptions


References