mahara-contributors team mailing list archive

[Mahara Bot <1858707@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10740
Committed: https://git.mahara.org/mahara/mahara/commit/e901c1b3f7b5ff5cc88c834d718aa621e3eabe66
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit e901c1b3f7b5ff5cc88c834d718aa621e3eabe66
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Wed Jan 8 14:15:19 2020 +1300

Bug 1858707 Skins header link colour

Change to use the same variable as the page title, and with
set underline and on hover

behatnotneeded

Change-Id: I87ffa780f169e5251c4f064a1ab32572be4c8eb4
(cherry picked from commit 25d9cdc067e837453199bb7ec76347882f1076d5)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1858707

Title:
  Links in a header with skin turned on shows normal link color instead
  of header color

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  The link color has not yet been changed in the header for a skin.

  It should match the header font color and links should be underlined
  to indicate that they are links.

  See attached screenshot.

  To replicate:

  1. Create a skin with:
  - Header background colour: #1A21F7
  - Header text colour: #FA0CFA
  2. Apply the skin to a page.
  3. Ensure that you give your page at least one tag.
  4. View the page.
  Expected result: Both the person's name and the tags should be displayed in pink and underlined.
  Actual result: The link colour set in the "Text" tab in the skin is used.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1858707/+subscriptions