mahara-contributors team mailing list archive

[Rangi Daymond <1800319@xxxxxxxxxxxxxxxxxx>]

- Gerrit: https://reviews.mahara.org/#/c/10633/ Patch set 12
- Browser/s tested: desktop Chrome
- Theme: Raw

Pre-requisites:
1. PersonA has the following pages set up with the noted share permission accesses:
- Page1 shared with PersonB role 'No special role'
- Page2 shared with Group1 (owner PersonA, members PersonB and PersonC)
- Page3 shared with 3 others (PersonC role 'Peer', PersonD role 'Manager' & PersonE role 'Peer and manager')
- Page4 not shared
- Page5 shared with PersonB role 'Peer and manager' and PersonE role 'No special role'
2. PersonA has pre-patch Collection1 (with 2 pages) shared with Group 1

Test case1: Add page to existing collection

1. PersonA navigates to 'Main menu' > 'Create' > 'Pages and collections' > 'Collection1' > 'Manage'.
Expected result: The 'Done' button text has been replaced by 'Next: Edit access'.   ✔

2. PersonA selects Page5 then clicks the 'Add pages' button.
Expected result: The 'Edit collection pages' page is updated to display the '1 page added...' message and the 'Add pages to collection' element is updated to display 'No pages are available to add.' and Page5 is added to the end of the 'Pages already in collection' element.   ✔

3. PersonA selects the 'Next: Edit access' button.
Expected result: The 'Edit access' page is displayed for Collection1 showing that it is shared with Group 1, PersonB role 'Peer and manager' and PersonE role 'No special role'.   ✔

4. PersonA selects 'Cancel'.
Expected result: The 'Pages and collections' page is displayed showing that Collection1 has 3 pages and Page5 is no longer present.   ✔

5. PersonA selects the 'Manage access' icon for Collection1
Expected result: 'Manage access' options are displayed for Collection1 showing that it is shared with Group 1, PersonB role 'Peer and manager' and PersonE role 'No special role'.   ✔


Test case2: Create collection from several pages

1. PersonA navigates to 'Main menu' > 'Create' > 'Pages and collections' > 'Add' > 'Collection', enters 'Collection name' Collection2 then selects 'Next: Edit collection pages'.
Expected result: The 'Edit collection' page is displayed with Page1 thru Page4 listed in the 'Add pages to collection' element and "No pages" displayed in the 'Pages already in collection' element and the 'Done' button text has been replaced by 'Next: Edit access' button.  

2. PersonA clicks the 'Add pages to collection' 'All' option then 'Add pages' then 'Next: Edit access'.
Expected result: The 'Edit access' page is displayed for Collection2 showing that it is shared with Group 1, PersonB role 'Peer and manager' and PersonE role 'No special role'.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1800319

Title:
  Revise merging of sharing permissions for a collection

Status in Mahara:
  In Progress

Bug description:
  When pages are added to a collection, all sharing permissions are
  merged and a notice provided on screen to the user so that they know
  it happened. However, the details are not mentioned.

  By merging sharing permissions, it can happen that one person or group
  is mentioned multiple times, e.g. when a page was shared without peer
  or manager permissions but then is added to a collection that contains
  these permissions. This can get confusing quickly as there are
  contradicting sharing permissions. Furthermore, in the case of the
  peer permission, it would give a peer access to portfolio content they
  shouldn't see.

  It would be beneficial if a user were able to review the sharing
  permissions after adding one or more pages to a collection so as not
  to overshare by accident.

  I see two scenarios:

  1. Leave things as they are when the sharing permissions for the
  collection and the newly added page(s) are identical and mention that
  in the info box at the top of the page.

  2. When the sharing permissions are not identical (for whatever
  reason), require the user to continue to the sharing permissions
  screen when clicking the "Done" button at the bottom of the page. It
  would not be enough to provide a link in an info box because they are
  easily overlooked. When the "Done" button is clicked, a modal should
  come up informing the user that they need to review the permissions as
  they have been merged.

  Potential text for the modal: The permissions of the newly added
  page(s) were merged into the existing collection permissions. Please
  review them carefully and make any necessary adjustments.

  Button text: Review (we don't need "Review permissions" as that is
  mentioned in the text and makes the button text very long; even more
  so in other languages)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1800319/+subscriptions