mahara-contributors team mailing list archive

[Rangi Daymond <1856506@xxxxxxxxxxxxxxxxxx>]

- Code/Gerrit: https://reviews.mahara.org/#/c/10717/ Patch set 1
- Browser tested: Chrome (test step2) and Win10-Edge (test step3 and 4)
- Theme: Raw

Preconditions:
1. Mahara site version 19.04 present.
2. Page1 with custom layout of 4 rows created with one block in row1, two blocks in row3 and one block in row4. Row 2 is empty/has no blocks.
3. Page2 created with 1 row layout with no block content.
4. Page3 created with 3 row layout, no block content in rows 1 and 3, 2 blocks in row 2.
5. Collection1 created with Page2 and Page3 in it.

Test steps:
1. Apply patch.
2. Login as PersonA and navigate to Page1 and edit it, 'Accept' page conversion, Page1 is translated and there is a message to show the process was successful ✔
3. Navigate to Collection1 Page2 and edit it, 'Accept' page conversion, Page2 is translated and there is a message to show the process was successful ✔
4. Navigate to Collection1 Page3 and edit it, 'Accept' page conversion, Page3 is translated and there is a message to show the process was successful ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1856506

Title:
  gridstack - too much recursion error when translating from old layout

Status in Mahara:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress

Bug description:
  If there is an old layout page with empty rows (no blocks in that
  row), when translating to new gridstack layout there will be a
  javascript error "too much recursion". This error will make the script
  fail and the process of translating will never be completed.

  
  To test:

  - have a Mahara site version 19.04 or older
  - make a page and set the layout to one that has more than 3 rows. It should have at least one block in row 1 and row 3. No blocks in row 2
  - upgrade the site to 19.10 or newer
  - go to the page and edit it

  expected result: the page is translated and there a message to show the process was successful
  actual result: there is a "too much recursion" error in the browsers console and the translation process is interrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1856506/+subscriptions