mahara-contributors team mailing list archive

[Mahara Bot <1859355@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10749
Committed: https://git.mahara.org/mahara/mahara/commit/438f2043a5915606df241a4f2831ef567cf57bc7
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    18.10_STABLE

commit 438f2043a5915606df241a4f2831ef567cf57bc7
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Jan 13 16:01:01 2020 +1300

Bug 1859355: Peers should not be able to delete other peer's assessment

To test: see bug report for steps

behatnotneeded

Change-Id: I1d345fcf033aca380e3367b130f24b68f737c0aa
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 8894df2c77457833ad2d0f5900c6a3c4b91d3e6a)
(cherry picked from commit d7fdaad8cd87bb169e58d1359b74551adefaccea)
(cherry picked from commit 141f3856bebd2bb0dc169981e31709ff986a7fd6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859355

Title:
  Peer assessor can delete another peers assessment

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  When we have the following setup:

  1) User A creates Page One and adds
  - a peer assessment block
  - a sign-off block

  2) User A shares Page One to
  - User B as 'peer'
  - User C as 'peer'
  - User D as 'no special role'

  3) Login as User B and add an assessment to Page One

  4) Login as User C and view Page One
  *** problem ***
   - you shouldn't be able to delete the peer assessment of User B

  This is also a problem when 'sign-off' block is not present

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859355/+subscriptions