mahara-contributors team mailing list archive

[Mahara Bot <1856506@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10752
Committed: https://git.mahara.org/mahara/mahara/commit/52c614c4e962ba37b17a4e489649d6eb8eaeac97
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit 52c614c4e962ba37b17a4e489649d6eb8eaeac97
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Wed Jan 15 11:26:39 2020 +1300

Bug 1856506: gridstack: adding extra checks for non numbers

behatnotneeded

Change-Id: I5096809eee056275d45c295dd6a7b37e9ca23f68
(cherry picked from commit ecfa80e383a495bb1623c3e5f4ccd94688c20dd2)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1856506

Title:
  gridstack - too much recursion error when translating from old layout

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  If there is an old layout page with empty rows (no blocks in that
  row), when translating to new gridstack layout there will be a
  javascript error "too much recursion". This error will make the script
  fail and the process of translating will never be completed.

  
  To test:

  - have a Mahara site version 19.04 or older
  - make a page and set the layout to one that has more than 3 rows. It should have at least one block in row 1 and row 3. No blocks in row 2
  - upgrade the site to 19.10 or newer
  - go to the page and edit it

  expected result: the page is translated and there a message to show the process was successful
  actual result: there is a "too much recursion" error in the browsers console and the translation process is interrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1856506/+subscriptions