mahara-contributors team mailing list archive

[Mahara Bot <1845228@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10380
Committed: https://git.mahara.org/mahara/mahara/commit/e48f88ced5feae30aebedaa8301682ab5f73f457
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit e48f88ced5feae30aebedaa8301682ab5f73f457
Author: Rebecca Blundell <rebeccablundell@xxxxxxxxxxxxxxx>
Date:   Thu Sep 26 13:49:07 2019 +1200

Bug 1845228: Make Mahara work with mysql 8.0.17

-Add mysql reserved words 'array' and 'member'
-Remove deprecated ||, &&, ! and replace with OR, AND, NOT
Note: Use of || is deprecated unless the PIPES_AS_CONCAT SQL mode is
enabled. In that case, || signifies the SQL-standard string
concatenation operator
-Quote uses of member in SQL queries
Note: when passed in as a variable it is quoted on query construction

behatnotneeded

Change-Id: I860bac5c44dab206b70a78215a5784e6f1fe3928

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1845228

Title:
  Mahara installation issues with MySQL 8.0.17

Status in Mahara:
  Fix Committed

Bug description:
  Hi,

  The latest version of Mahara (19.04.1) throws the following error when
  running the install.php script

  ```
  [INF] fe (admin/cli/install.php:74) Installing Mahara
  [INF] fe (lib/mahara.php:237) Installing core
  [DBG] fe (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'member BIGINT(10) NOT NULL,
  [DBG] fe (lib/dml.php:157)     role VARCHAR(255) NOT NULL,
  [DBG] fe (lib/dml.php:157)     ctime DATETIME N' at line 3] in EXECUTE("CREATE TABLE group_member (
  [DBG] fe (lib/dml.php:157)     `group` BIGINT(10) NOT NULL,
  [DBG] fe (lib/dml.php:157)     member BIGINT(10) NOT NULL,
  [DBG] fe (lib/dml.php:157)     role VARCHAR(255) NOT NULL,
  [DBG] fe (lib/dml.php:157)     ctime DATETIME NOT NULL,
  [DBG] fe (lib/dml.php:157)     method VARCHAR(100) NOT NULL DEFAULT 'internal',
  ```

  The command we run during the installation process is the following
  one:

  ```
  php "/mahara_folder/admin/cli/install.php" --adminpassword=PASSWORD --adminemail=EMAIL
  ```

  We are using the latest version of MySQL (8.0.17) as database and
  "member" is a reserved word from that version on.

  https://dev.mysql.com/doc/refman/8.0/en/keywords.html

  Regarding the OS, we detected this problem in Linux and Windows (OS X
  is probably affected as well).

  Let me know if you need more information and if you have a workaround
  to install the application with this version of the database.

  Thanks,
  Jota

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1845228/+subscriptions