mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

My initial patch was a blunt instrument and doesn't fix the underlying
problem

The problem seems to only exist for gridstack pages

And the bits of code that seem to be bad are:

        var blockContent = $('<div id="block_' + block.id + '"><div class="grid-stack-item-content">'                         
            + block.content +                                                                                                 
            '<div/><div/>');  

this bit above puts 'null' on the page because the content is set to
null

and the following bit

            $(element).find('.grid-stack-item-content
.gridstackblock')[0].scrollHeight +

Throws this console error

TypeError: $(...).find(...)[0] is undefined

because there is no content to find the scrollHeight of

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1867999

Title:
  Empty annotation in peer review mode is not working right

Status in Mahara:
  In Progress

Bug description:
  To test:

  1) Create a page with both the annotation and peer assessments on it -
  have content for both

  2) Share it with another user with 'peer' role

  3) Login as other user and view page

  You should see the word 'null' where the title should be

  This is because the block tries to hide the title when content is
  empty, which it is in this case as a peer can't see the blocks content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1867999/+subscriptions