mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #57781
[Bug 1867999] A change has been merged
Reviewed: https://reviews.mahara.org/10832
Committed: https://git.mahara.org/mahara/mahara/commit/217d1749aa77a7843c12aa6e574d1b495bb95912
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch: 19.10_STABLE
commit 217d1749aa77a7843c12aa6e574d1b495bb95912
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date: Fri Mar 20 15:11:34 2020 +1300
Bug 1867999: the annotation block should be empty if no title and no
content
behatnotneeded
Change-Id: Ida169d4f569b9406ca350e84ecd867a9002af945
(cherry picked from commit 5d9ccc3eed5ef522a15ceaf21f4f8aab1a3c9cc0)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1867999
Title:
Empty annotation in peer review mode is not working right
Status in Mahara:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Bug description:
To test:
1) Create a page with both the annotation and peer assessments on it -
have content for both
2) Share it with another user with 'peer' role
3) Login as other user and view page
You should see the word 'null' where the title should be
This is because the block tries to hide the title when content is
empty, which it is in this case as a peer can't see the blocks content
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1867999/+subscriptions
References