mahara-contributors team mailing list archive

[Mahara Bot <1867707@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10827
Committed: https://git.mahara.org/mahara/mahara/commit/01cab2e421a2ea35935fdf5c849a8d6b5d55d321
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 01cab2e421a2ea35935fdf5c849a8d6b5d55d321
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Wed Mar 18 14:20:16 2020 +1300

Bug 1867707 Add comments and details block header active state

Moved styles to the right path for active states to been seen when
a block's add comments/details opens up a modal.

- added in more specific target to folder_render_in_modal to prevent
the wrong event being called on open_modal func

behatnotneeded

Change-Id: I78d647e44f938de432a4757b309bca7caae3adcb

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1867707

Title:
  Add comments and details block headers not changing colour when active

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  When a block on a page is viewed in "details" mode the block comments
  and details header can be seen.  When selected to open the associated
  modal the background colour of the bar of the heading should change
  colour to indicate the block that was selected.

  To reproduce:
  1. Log in as any person and create a page
  2. Create an image block and display the page.
  3. Select "Details" mode to turn it on and view the block detail headers
  4. Click on the header to open the details modal and look at the block detail header on the page
  Expected result:
  The active block header background colour has changed.
  Actual result:
  The block header header background colour has not updated (remains black in raw).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1867707/+subscriptions