mahara-contributors team mailing list archive

[Mahara Bot <1857379@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10783
Committed: https://git.mahara.org/mahara/mahara/commit/015a94823dc242dda6152e84cf4b9e3a39e442f3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 015a94823dc242dda6152e84cf4b9e3a39e442f3
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Fri Feb 28 10:12:17 2020 +1300

Bug 1857379: File attachment display consolidation

- altered templates to remove file size info, always show download icon
- create modal links where needed
- remove attachment panels in resume education/employment history and achievements

Change-Id: Ie8ecf4c73e698d45332c250a59c23b374413d841
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857379

Title:
  File attachment display consolidation

Status in Mahara:
  Fix Committed

Bug description:
  Currently, we rely on hover for easy downloading of files that have
  been attached to a block, e.g. note or resume item. We are also
  double-coding that area:

  1. The link takes you to the modal where you see the details of the file.
  2. When you click anywhere else in the area (where there is also a hover effect), you can download the file directly.
  3. You can click on the download icon that shows up when you hover over the file and its surrounding space to download the file.

  It will be better to clean that up to support mobile better and
  prevent confusion about what is happening in the individual cases.

  1. Remove the grey hover effect (it is also difficult to retain accessibility contrast to links and the download icon).
  2. Remove the download icon and link.
  3. Remove the size information as it becomes irrelevant without the download link. It will be displayed in the modal.
  4. Remove the date information. The date is not always relevant as it is the upload date rather than the file creation date. It can be seen in the modal.
  5. Retain the link to the file that takes you to the modal from where you can download the file and see all the details for the file.
  6. Add the "Description" as already happens in "Files to download" and use "class=midtone". Like with "Files to download", description should sit on its separate line right below the file name.

  Every block that can have a file attachment needs to be reviewed and
  consolidated:

  1. Notes
  2. Full resume
  3. One resume field
  4. Files to download
  5. Folder
  6. Journal
  7. Journal entry

  and while you are at it, please also add the attachment panel to:

  a) Recent journal entries
  b) Tagged journal entries

  They are missing there at the moment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857379/+subscriptions