mahara-contributors team mailing list archive

[Mahara Bot <1855373@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10657
Committed: https://git.mahara.org/mahara/mahara/commit/6f7b1aca7e445e3043383d5e84b7704b14840ff1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 6f7b1aca7e445e3043383d5e84b7704b14840ff1
Author: Rebecca Blundell <rebeccablundell@xxxxxxxxxxxxxxx>
Date:   Mon Dec 9 09:59:50 2019 +1300

Bug 1855373: Gulp update to v4

Changes to gulpfile to make Gulp 4 work
Removed gulp-help
update yargs to latest version to avoid potential vulnerability

Change-Id: Ia2f085372b8b8d3d40252686e183271f6b91ebe3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1855373

Title:
  Update gulp

Status in Mahara:
  Fix Committed

Bug description:
  A while ago we pinned Gulp to version 3.9 to prevent a problem with
  dependency incompatibility. We now need to upgrade Gulp to version 4
  to get rid of vulnerabilities in some of its dependencies.

  What needs to happen:
  1. Check for dependency incompatibility with Gulp 4 to see if it's still an issue. If so, can we work around it?
  2. See what's involved with upgrading to Gulp 4
  3. We could look at the dependencies we are including for gulp (and maybe node dependencies too, although this could be a separate issue) and confirm that they are needed in Mahara.

  Investigation of the above points:

  1. The only dependency we have now that is incompatible with v.4 seems to be gulp-help. It doesn't look like it will cause any problems to remove it, so we should just remove it.
  2. There are syntax changes that need to be made, but it looks like they can be made in the gulpfile.js, which limits the coding to be done.
  Assumption made: There are no wider changes necessary.
  3. Not looked at at this stage.

  Gulp docs:
  https://gulpjs.com/docs/en/getting-started/quick-start

  3rd party links:

  https://stackoverflow.com/questions/36897877/gulp-error-the-following-tasks-did-not-complete-did-you-forget-to-signal-async
  https://stackoverflow.com/questions/50505275/gulp4-assertionerror-task-never-defined-when-calling-or-importing-tasks
  https://codeburst.io/switching-to-gulp-4-0-271ae63530c0
  https://coder-coder.com/gulp-4-walk-through/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1855373/+subscriptions