← Back to team overview

mahara-contributors team mailing list archive

[Bug 1868657] Re: Image Gallery blocks that display from individually images don't have the details block header

 

Checking the code I can see we only display the modal with details for
blocks that have only one artefact id.

For blocks with many artefacts the idea seems to be to display the
details as a header in each artefact. For blocks with only one artefact,
there is a header in the block that will display the modal.

For image gallery blocks it displays a modal when the images all belong
to the same folder, because the artefact associated with the block is
the folder.

Following this idea, if we add an image gallery block and select the
images instead of a folder, then each image should have the 'Details'
header. But I don't think this will look good so another alternative
would be to try to render the images as we render the list of images
inside a folder.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1868657

Title:
  Image Gallery blocks that display from individually images don't have
  the details block header

Status in Mahara:
  In Progress

Bug description:
  When an image gallery block is created with images selected from a
  folder it correctly displays a 'Details' block header over the block
  in 'Details' mode with the links to open the details in the modal.

  When an image gallery block is created with individually selected
  images, the image gallery will display but it is missing the details
  header.

  An investigation is needed as to how best to display the details
  header, i.e when displaying from a folder the gallery uses the same
  template as the folder block.  We should see what is possible when we
  display from individual images.

  Steps to reproduce:

  Pre-requisites:
  Have a site, a user (any role) who can log in and create a page and some image files uploaded.
  1. Log in and create a new page
  2. Add the Image Gallery block and choose and under "Image Selection" select "Choose individual images to display"
  3. Select images and then save the block
  5. Display the page and select "Details" mode
  Expected results:
  The Image gallery block displays with some kind of details header to reach the details modal
  Actual results:
  The Image gallery displays without any kind of details header

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1868657/+subscriptions


References