mahara-contributors team mailing list archive

[Mahara Bot <1870993@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10846
Committed: https://git.mahara.org/mahara/mahara/commit/8c2f50f934ff38febfb6a4a7b100c7d80fd86160
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 8c2f50f934ff38febfb6a4a7b100c7d80fd86160
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Apr 3 18:19:53 2020 +1300

Bug 1870993: Respect $cfg->usepdfexport value

If all other dependencies are met then it is possible to export by pdf
on new installs without $cfg->usepdfexport set

Change-Id: I7a61e88ba835609564f1aaeaa46be89b82bd8974
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1870993

Title:
  Site not respecting the usepdfexport flag

Status in Mahara:
  Fix Committed

Bug description:
  With the new pdfexport option there are a few things that need to be
  true before it is used.

  1) The chrome-php plugin needs to exist
  2) The $cfg->usepdfexport setting needs to be true
  3) The active setting in export_installed table needs to be true

  However, it will still do the export if point 1 and 3 are true -
  ignoring the usepdfexport flag - if installing a new site (not
  upgrading)

  To test (before patch):

  1) checkout master
  2) run make pdfexport - and also make sure any other pdfexport dependencies are met eg pdfunite
  3) set config.php with: $cfg->usepdfexport = false;
  3) install site
  4) do an export and see pdf being built in it

  So we neeed to adjust the code so that all three things are respected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1870993/+subscriptions