mahara-contributors team mailing list archive

[Mahara Bot <1871722@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10884
Committed: https://git.mahara.org/mahara/mahara/commit/3781ecf6a470c67be2579a43d37e4b625d3a416d
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.04_STABLE

commit 3781ecf6a470c67be2579a43d37e4b625d3a416d
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Thu Apr 9 10:12:21 2020 +1200

Bug 1871722: add cancel button to Collections manage views

to get the url for the cancel button I added back the code removed here
https://reviews.mahara.org/#/c/10633/12/htdocs/collection/views.php

behatnotneeded

Change-Id: I29e17a2dd5ffca4b69c9bb6c547af0ff3c848177
(cherry picked from commit 3d364fba18d48803c9beb5e29c54cd487a52e02d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1871722

Title:
  manage collection pages: needs a cancel button and missing lang string

Status in Mahara:
  Fix Committed

Bug description:
  to replicate

  - have a collection with one view
  - go to manage the views in the collection (in pages and collections, click the bottom menu in the collection card)
  - delete the view from the list so the collection has no more views in it
  - click on "Next: Edit access"

  result

  - there is an error message displayed because you can't edit access on
  an empty collection, but there's no cancel button and the string in
  the message is broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1871722/+subscriptions