mahara-contributors team mailing list archive

[Mahara Bot <1866773@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10918
Committed: https://git.mahara.org/mahara/mahara/commit/7fe7ff55e23996cbbe7734aedaf2db6b2d47d00b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.04_STABLE

commit 7fe7ff55e23996cbbe7734aedaf2db6b2d47d00b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Mar 10 20:45:30 2020 +1300

Bug 1866773: Count array instead of integer

Change-Id: Ifed601c60ff953577f01dc01e335accc87646414
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 214d7db684f9acac90b784362c93e1e9a13e94a2)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1866773

Title:
  Auth SAML get disco list issue

Status in Mahara:
  Fix Committed

Bug description:
  [WAR] 16 (auth/saml/lib.php:719) count(): Parameter must be an array
  or an object that implements Countable

  We are returning 0 if there are no disco lists and then try to do a
  count on them which is not correct.

  We should return an empty array and use count on that

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1866773/+subscriptions