← Back to team overview

mahara-contributors team mailing list archive

[Bug 1873121] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10912
Committed: https://git.mahara.org/mahara/mahara/commit/5e5cf6c15598b71114abb003a70ab22b8eb05d92
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 5e5cf6c15598b71114abb003a70ab22b8eb05d92
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Apr 21 15:42:03 2020 +1200

Bug 1873121: HTML / PDF export of Gallery block in slideshow mode is
broken

- added carouselHeight() in to viewcontent.tpl to fix display for export preview modal
- added carouselHeight() to export view.tpl to fix display for html export
- added in script tags to export header.tpl to include neccessary funcs
- added code changes to raw, custom theme.js
- added window level scope to carouselHeight ()

Change-Id: I93c44b1b356434eac2d4b8a062166528eaa07999
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1873121

Title:
  HTML / PDF export of Gallery block in slideshow mode is broken

Status in Mahara:
  Fix Committed

Bug description:
  In HTML, all images display on top of each other & when control
  selected image ‘peeks’ out from underneath but doesn’t come to the top

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1873121/+subscriptions


References