mahara-contributors team mailing list archive

[Mahara Bot <1839411@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10930
Committed: https://git.mahara.org/mahara/mahara/commit/81061243204a63c66fd558deffef433c8a1e8b01
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit 81061243204a63c66fd558deffef433c8a1e8b01
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Apr 24 16:46:49 2020 +1200

Bug 1839411: Update Mahara to work with PHP7.3

Fixed strpos error picked up by 7.3
I haven't found any other 7.3 issues and none have been caught by behat

Change-Id: Icfea5fa01fa854ca0d49bd977b4ad507497b4b02
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1839411

Title:
  Update codebase for php 7.3 and php 7.4

Status in Mahara:
  Fix Committed

Bug description:
  I tried running behat tests in php 7.3 and among other issues got the
  following error due to a PHP 7.3 deprecation:

  /code/mahara/test/behat/features/site_features/smart_evidence_editor.feature:8
          8192: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in ~/code/mahara/htdocs/lib/mahara.php line 1620

  This made me think we should check the code for this and other 7.3 issues. Notes on migrating to 7.3:
  https://www.php.net/manual/en/migration73.php

  And on migrating to 7.4:
  https://www.php.net/manual/en/migration74.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1839411/+subscriptions