← Back to team overview

mahara-contributors team mailing list archive

[Bug 1874375] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10927
Committed: https://git.mahara.org/mahara/mahara/commit/26ee364fd805356805ddd11919ee662d93f87a75
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 26ee364fd805356805ddd11919ee662d93f87a75
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 23 16:28:35 2020 +1200

Bug 1874375: Allow the uploading spinner message not have success tick

The tick should only appear after the file has finished uploading
- made alert-pending css class to handle this

Change-Id: I757a0e66fe5bc9ac8024f4082bf02dc5afe62db6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1874375

Title:
  file uploading message has a 'tick' background

Status in Mahara:
  Fix Committed

Bug description:
  When a file has successfully uploaded it has a success message with a
  tick, which is good

  But since we moved the success tick icon to be in css :before class we
  show the tick at the same time we show the uploading spinner icon.

  We should fix this by making a new option 'alert-pending' that has the
  same colours as the alert-success but without the 'tick' icon

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1874375/+subscriptions


References