← Back to team overview

mahara-contributors team mailing list archive

[Bug 1871280] Re: Allow grouproles to be reset for users when roles updated via webservices

 

This problem doesn't exist in master / 20.04 as there were two related
changes there that fixed this problem

As one of the changes was done in 19.10 we will add the other fix there
to sort the problem - will make a new patch for that

The fix in patch 10864 will sort out the problem for mahara 19.04 if
anyone needs it - but we will not merge into 19.04 branch as it would be
a wishlist item there - new code rather than fixing existing code.


** Also affects: mahara/19.04
   Importance: Undecided
       Status: New

** Also affects: mahara/19.10
   Importance: Undecided
       Status: New

** Changed in: mahara/19.04
   Importance: Undecided => Wishlist

** Changed in: mahara/19.10
   Importance: Undecided => Medium

** Changed in: mahara/19.10
    Milestone: None => 19.10.4

** Changed in: mahara/19.04
       Status: New => Won't Fix

** Changed in: mahara
   Importance: Wishlist => Medium

** Also affects: mahara/20.10
   Importance: Medium
       Status: In Progress

** Also affects: mahara/20.04
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1871280

Title:
  Allow grouproles to be reset for users when roles updated via
  webservices

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  Won't Fix
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  In Progress

Bug description:
  When creating new groups via webservices while the user is logged in.

  The "group/find.php" search works with a user's grouproles and when a
  group is created via webservice the grouproles are not reset for the
  session. So only after the user logged out and logged in again, the
  group is found with "group/find.php".

  We need to set a flag so that when a person loads anything in mahara
  (eg calls the $user->renew() function) that it resets the group roles
  for the user so they don't have to logout and login again.

  Added from discussion with Robert (2020-05-08):
  The group_add_user() and group_remove_user() functions already call the $USER->reset_grouproles() function - so this patch is only fixing the problem when group_create() is called. In 'normal' Mahara we can't create a group with more than the current user, but via webservice we can create a group with many members at once and that causes this problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1871280/+subscriptions


References