mahara-contributors team mailing list archive

[Mahara Bot <1871280@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10978
Committed: https://git.mahara.org/mahara/mahara/commit/5c7ff29d6d7f3bff74853f1592ebf9363612cc77
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.04_STABLE

commit 5c7ff29d6d7f3bff74853f1592ebf9363612cc77
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri May 8 16:21:26 2020 +1200

Bug 1871280: Using correct search with 'Groups I am in' during
pagination

Change-Id: I7f2f80c350ba45dfdf2953eac193188c57f27c2c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit a357f8cc471af8513cee130cc7580b9c753fa04a)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1871280

Title:
  Allow grouproles to be reset for users when roles updated via
  webservices

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Won't Fix
Status in Mahara 19.10 series:
  Won't Fix
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When creating new groups via webservices while the user is logged in.

  The "group/find.php" search works with a user's grouproles and when a
  group is created via webservice the grouproles are not reset for the
  session. So only after the user logged out and logged in again, the
  group is found with "group/find.php".

  We need to set a flag so that when a person loads anything in mahara
  (eg calls the $user->renew() function) that it resets the group roles
  for the user so they don't have to logout and login again.

  Added from discussion with Robert (2020-05-08):
  The group_add_user() and group_remove_user() functions already call the $USER->reset_grouproles() function - so this patch is only fixing the problem when group_create() is called. In 'normal' Mahara we can't create a group with more than the current user, but via webservice we can create a group with many members at once and that causes this problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1871280/+subscriptions