mahara-contributors team mailing list archive

[Mahara Bot <1857382@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10742
Committed: https://git.mahara.org/mahara/mahara/commit/500d91796bef507f115dce007fe6eb9e43b58f0c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 500d91796bef507f115dce007fe6eb9e43b58f0c
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Fri Jan 31 15:59:04 2020 +1300

Bug 1857382: Removing page description tinymce editor

and replace the editor with a textarea to edit the description

For views already on the site that have descriptions:
- If they can be transform to a simple text, then remove the html
tags from the view description to make it a simple text and
update the DB with it.
- If the description has tables, lists, etc, then create
a text block with that description and place it above
the other blocks of the view.

upgrade: only remove description for new layout pages
and the description must be:
- more than 160 characters long
or
- have styling tags other than <p>, <em>, <br>

translating pages: if the description makes one of the
two conditions true, then create a new block at the top
of the page with it. If not, if it's a simple short text
then leave it as the view description.

import:
- for new gridstaxc layout pages, add a block at the top if needed.
- for old layout, the page will be translated. After this, we
add a block if needed

copy a page:
- if it has new gridstack layout, it was fixed by the upgrade,
so we don't need to do anything
- if it has old layout, the new view will be translated and
we add a new text bloxk at the top with the description if needed

CHECK what to do
- the site templates, Dashboard and profile pages have descriptions
So do the copies for each user.
But those description don't show when viewing a portfolio or a dashboard.
And the user can't change the settings for those pages either.
old pages not translated: display a new block at the top of the page.
There's no change in the layout on the db, there will be a mock block
at the top of the page

behatnotneeded
Change-Id: I7646405a786e823ae486cc325c30b7a713deccee

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857382

Title:
  Remove WYSIWYG options for page description

Status in Mahara:
  Fix Committed

Bug description:
  In the past when the layout was not very flexible and we didn't have
  rows (i.e. a veeeeery long time ago), the page description text field
  was an important part of a page as it allowed people to create a
  section across an entire page of Mahara and use it as style element.
  People created banners in there and needed to have styling options
  available. That's why it has a visual editor with all the editing
  options.

  Now (well, for quite some time already actually) that we have a more
  flexible layout, we do not need this area anymore to style a page
  with. It also added to the confusion for some people as they thought
  that was the area where they would add their content.

  While the page description is shown on a page, the collection
  description is ignored (this may be a regression, but is OK).

  Since we have the "tiles" on "Pages and collections", the description
  shows up in the tile and is often cut off when it is too long and
  banners are not displayed in there either.

  I propose the following:

  1. Remove the visual editor from the page description.
  2. Limit the number of characters for the page and collection description to 140 characters. That seems to fit in there (with our current font size).
  3. For existing sites, move the current page description content of pages to the first block on the page that goes across the entire width of the page and doesn't have a block heading. That way, the content is still displayed for pages that are used to displaying it, especially if the page uses the description as content styling element.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857382/+subscriptions