mahara-contributors team mailing list archive

[Mahara Bot <1880771@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10996
Committed: https://git.mahara.org/mahara/mahara/commit/9d0172495296e88975643a0667f7e04666a85a74
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 9d0172495296e88975643a0667f7e04666a85a74
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed May 27 11:01:16 2020 +1200

Bug 1880771: Closing the 'add group membership' modal on saving

Fixing up the css selector in the js

Change-Id: I2efa1d69e06694cd3eb09ad17d40e835077c7d9e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 74704ecc1a964d9839b4e5b4a7a634524979c38c)
(cherry picked from commit b5b818c8f342978354e6f118d23f6bd52cab16b0)
(cherry picked from commit 19256304042dff7fb9760d81262894b50f4ab19f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880771

Title:
  When adjusting group membership via the Engage -> People page the
  modal doesn't close on submit

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  This is because the js is expecting .modal.in when it actually has
  .modal.show

  To test:
  Make sure you have a site with some users and groups

  Login in as admin and go to Engage -> People
  Click on 'Edit group membership' for a user
  Select a group either in the Add member or Invite parts and click on 'Apply changes'

  The modal should close on saving

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1880771/+subscriptions