mahara-contributors team mailing list archive

[Mahara Bot <1884473@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11031
Committed: https://git.mahara.org/mahara/mahara/commit/52e94ebe608fcb684d54f4e4bfd24b06fbda560d
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 52e94ebe608fcb684d54f4e4bfd24b06fbda560d
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Jun 22 15:02:27 2020 +1200

Bug 1884473: Check row.attachments is defined first

Before checking if its count greater than 0

Change-Id: Idfc7e8272698a71abd616c0c6d79cbede65ec4d5
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1884473

Title:
  Resume js error when saving without attachment

Status in Mahara:
  Fix Committed

Bug description:
  When we save we get sendjsonrequest() callback failed:  TypeError:
  "attachments is undefined"

  And a bit of code tries to check if undefined is less than 0

  I'm not sure how this used to work but it doesn't now in latest
  Firefox

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1884473/+subscriptions