mahara-contributors team mailing list archive

[Mahara Bot <1885784@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11058
Committed: https://git.mahara.org/mahara/mahara/commit/974787e578fcdaa127ab42bd9ab3145483ac34f0
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 974787e578fcdaa127ab42bd9ab3145483ac34f0
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Wed Jul 1 10:41:14 2020 +1200

Bug 1885784: Need to update site options submit function to use alias

- altered the \"admin\" to use an alias instead

Change-Id: I3fb3cc7374619dc68bc101ddd0fdbc743a3583ac
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit f67ae229c7207cab5d057e56a01381195a75eff7)
(cherry picked from commit 951eab0685293ba9a47a41bc1f2f4a3e82efbafb)
(cherry picked from commit 8fe9483308aeef93cd728decbdc16ce242f30701)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885784

Title:
  Need to update site options submit function to use alias

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently our code base is using a database call with a query that
  contains a term inserted in escaped characters.  It is more robust and
  safer to use an alias rather than rely that variables put into escaped
  quotes will always reliably work.

  The DB query in question is in admin/site/options.php during the
  siteoptions_submit().

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885784/+subscriptions