← Back to team overview

mahara-contributors team mailing list archive

[Bug 1887317] Re: LoadXML error when upgrading from 18.10 to 20.04

 

to test follow steps

- have a mahara site 18.10
- add a comment to a page 
- go to the DB and check the id of the comment

select * from artefact where artefacttype='comment'
- change the artefact description to a malformed xml

update artefact set 
description ='<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd";>
<html><body>
<p class="a" align="center"><strong><span lang="EN-US">Title</span></strong></p>
<p class="a"><span lang="EN-US">Random text.</span></p>
<p class="a"><span lang="EN-US"><img src="data:image/png,iVBORw0'
where id = <artefact id>;

- change the code to master branch
- upgrade

excepted result: the site upgrades without any errors
actual results: the upgrade will show errors like the ones shown in the image attached to this bug report

** Changed in: mahara/20.10
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887317

Title:
  LoadXML error when upgrading from 18.10 to 20.04

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  New
Status in Mahara 19.10 series:
  New
Status in Mahara 20.04 series:
  New
Status in Mahara 20.10 series:
  In Progress

Bug description:
  There is a malformed xml in artefact description that will produce an
  exception when running upgrades for code to related to following bug

  https://bugs.launchpad.net/mahara/+bug/1826948

  we might need to catch this exception when calling LoadXML during the
  upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887317/+subscriptions


References