← Back to team overview

mahara-contributors team mailing list archive

[Bug 1883471] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11023
Committed: https://git.mahara.org/mahara/mahara/commit/35bad6d65de2ae8cc2f40eac6cc7fda377febeea
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 35bad6d65de2ae8cc2f40eac6cc7fda377febeea
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Mon Jun 15 16:42:19 2020 +1200

Bug 1883471: reduce margin bottom in blocks

reduced the empty space at the bottom of a block by:
1. removed the height of the resize handler elements
when the view is displayed
2. reducing the height of the gridstack rows from
the default 60px to 10px

behatnotneeded

Change-Id: I4a339fca31ffe9393f98e2beb9658e8c6072bb21

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883471

Title:
  reduce block margin on gridstack

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is too much bottom margin on the blocks when they are in display mode.
  This could be due to the margin of the resize handlers we have on edit mode (check image attached), where we set the block size. There is no need for this margin on display since we don't have the handlers there

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883471/+subscriptions


References