mahara-contributors team mailing list archive

[Mahara Bot <1885046@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11054
Committed: https://git.mahara.org/mahara/mahara/commit/c8f9aefbface99553bd411f9399b2a7a45246c66
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit c8f9aefbface99553bd411f9399b2a7a45246c66
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Fri Jul 3 10:16:33 2020 +1200

Bug1885046 Theme colour contrast for <code> tag

Changed the value of $pink in bootstrap in raw to pass contrast.

behatnotneeded

Change-Id: Id295e302a033f187e9520465976e38bfc6176b5f

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885046

Title:
  Theme colour contrast fails for <code> tag

Status in Mahara:
  Fix Committed

Bug description:
  There appears to be a <code> tag used throughout Mahara which has styling that is failing contrast checks.
  When inspecting an element inside of <code> tags, the styling is as follows:
  code {
      font-size: 87.5%;
      color: #e83e8c;
      word-break: break-word;
  }

  The colour values are failing the colour contrast for normal text in
  this tool found here: https://webaim.org/resources/contrastchecker/

  The <code> tag features in these places:
  Admin menu -> Configure site -> Site options -> Security settings help text for:
  pathtoclam, 
  pathtofile,
  remoteavatars,
  viruschecking

  Admin menu -> Extensions -> Plugin administration -> Elasticsearch help text:
  affecting 11 files (all of the help text files)

  The styling of the <code> will need to be either updated, or perhaps
  discarded in favour of a different element and class instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885046/+subscriptions