← Back to team overview

mahara-contributors team mailing list archive

[Bug 1887317] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11085
Committed: https://git.mahara.org/mahara/mahara/commit/f81006fa4f9c431dbfb0c8aafbf055698c51c9e9
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit f81006fa4f9c431dbfb0c8aafbf055698c51c9e9
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Mon Jul 13 13:02:27 2020 +1200

Bug 1887317: ignore warning from malformed xml in LoadXML

in 19.04 we added an upgrade step for
https://bugs.launchpad.net/mahara/+bug/1826948
to fix comments descriptions but it will throw
warning if the xml is malformed
the code will fix the xml anyway, but we should
prevent it to display the warnings as is they were
errors in the upgrade page

behatnotneeded

Change-Id: Iab6eed353a1b17876e3037b591633367d4d96d1a
(cherry picked from commit a3383fc2e89bfc8e4cc6e0aea6023b0e9e288955)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887317

Title:
  LoadXML error when upgrading from 18.10 to 20.04

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a malformed xml in artefact description that will produce an
  exception when running upgrades for code to related to following bug

  https://bugs.launchpad.net/mahara/+bug/1826948

  we might need to catch this exception when calling LoadXML during the
  upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887317/+subscriptions


References