mahara-contributors team mailing list archive

[Mahara Bot <1877001@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10964
Committed: https://git.mahara.org/mahara/mahara/commit/04382251a5e08325835be3b747dfa35b2f9ba5cc
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 04382251a5e08325835be3b747dfa35b2f9ba5cc
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri May 8 14:00:09 2020 +1200

Bug 1877497: Sorting out problems with skin export / import

This is a follow on for Bug 1877001

Fixed:
- using a defaultviewskin array so tha
1) all options are in one place
2) when importing older skins it sets missing values
3) when editing an older skin it only saves keys for what we have
defined in default options

- adding header_background_image to the export

Change-Id: I5a3d82f656f465e74551349fcbf9d76f22ba59bf
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877001

Title:
  Skins not showing after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When upgrading from an older site to 19.10+ site the skins stop
  showing on pages

  and there are error messages in the logs regarding this

  * error(8, "Undefined index: view_block_header_font",
  "/var/www/skin/style.php", 82, array(size 68)) at
  /var/www/skin/style.php:82

  We need an upgrade step to add in blank values for the 2 new fields

  view_block_header_font
  view_block_header_font_color

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877001/+subscriptions