mahara-contributors team mailing list archive

[Mahara Bot <1888743@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11126
Committed: https://git.mahara.org/mahara/mahara/commit/c640247ee35318eb9516ae6d8c15511bee3f3be0
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit c640247ee35318eb9516ae6d8c15511bee3f3be0
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Jul 30 12:40:46 2020 +1200

Bug 1888743: clean up references to old menu structure

- updated old references using set_nav func when appropriate
- delete peerassessment/edit.php as it's no longer used

Change-Id: Iabba2d703a89cce5655d4d6220caf352bf53ab1e
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
(cherry picked from commit fa72b91e0cc75a5824db75569ce3ec2a0f3d897b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently we still have some references to the old menu structure within Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions