mahara-contributors team mailing list archive

[Mahara Bot <1890238@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11113
Committed: https://git.mahara.org/mahara/mahara/commit/36cc477a3830b8a25a4ff2e1fd68118f5ec5c4b1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 36cc477a3830b8a25a4ff2e1fd68118f5ec5c4b1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Aug 5 13:29:42 2020 +1200

Bug 1890238: Stop the double 'Quick edit' bars appearing

Problem here was we we adding another bar unhidden to the existing
hidden one

Also allow the collapse to be a bit taller to show the title part

Change-Id: Ia40af96d6c08f9ef11563c865d36e5a3f7499a56
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890238

Title:
  Text block 'Quick edit' retract and double bar display issues

Status in Mahara:
  Fix Committed

Bug description:
  Test environment: current master
  Browser: Chrome (latest)

  Test steps:
  1. As a logged in person, create a new page "Test page".
  2. Add a text block as follows:
     - block title "Text Block"
     - leave the instructions blank
     - insert some content in the text block
     - set retractable to "Yes"
     - Save the block.
  3. Select to view/display the page.
     Expected result: ✔ The page is displayed with the "Quick edit" bar, 
       the content is NOT retracted.
     Actual result: as expected.
  4. Select to retract the block content then expand it.
     Expected result: X The block content is retracted then expanded correctly.
     Actual result: The block content is retracted but so is most of the "Quick edit" bar.
     The page must be reloaded to display correctly.
  5. (Reload the page) Select the "Quick edit" bar, the 'Text Block" edit panel is displayed,
     update the block content then Save.
     Expected result: ✔ The content change is displayed.
     Actual result: as expected.
  6. Select the "Details" icon (top right of screen).
     Expected result: The 'Text Block" edit panel is displayed.
     Actual result: X The "Quick edit" bar disappears.
  7. Select the "Details" icon again (top right of screen).
     Actual result: X Two "Quick edit" bars are displayed.
     
  Please see attached mp4 video file

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890238/+subscriptions