mahara-contributors team mailing list archive

[Mahara Bot <1891949@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11166
Committed: https://git.mahara.org/mahara/mahara/commit/37ee3bfb36f44c63dde2a2a0ae2b30661feb00b1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.04_STABLE

commit 37ee3bfb36f44c63dde2a2a0ae2b30661feb00b1
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Fri Aug 21 09:17:31 2020 +1200

Bug 1891949: don't use saved height for signoff blocks

and add a function to make it possible for other blocks
that have different contents in edit/view modes
to ignore the height and let the gridstack library resize

behatnotneeded

Change-Id: I471e35d3881d7f3654cd508f7de31ebfdedfbc5c
(cherry picked from commit db35d4e8cc79bee98933f87cabad83f8014acc07)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891949

Title:
  sign off block height on gridstack

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  The sign off block content is very different when editing the page from when viewing the page. This makes the block have a lot of extra space when viewing the page. We can make the height be predefined for viewsing since it will always have the same content, it can only have
  Sign off / Verify lines
  or
  Sign off alone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891949/+subscriptions