← Back to team overview

mahara-contributors team mailing list archive

[Bug 1891939] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11163
Committed: https://git.mahara.org/mahara/mahara/commit/0493cecc8491214be8c7473d2f3e0cdd77774d3b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.10_STABLE

commit 0493cecc8491214be8c7473d2f3e0cdd77774d3b
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Tue Aug 18 11:09:14 2020 +1200

Bug 1891939: remove references to mce-tinymce class

when upgrading to TinyMCE 5, on commit ada3e2cd6f87c8d22980f28ffe0dc957308796aa
the theme/raw/sass/lib/_tinymce.scss

the mce-tinymce class from the editor is changed to tox-tinymce

we should remove the references from the code to that class
in the jQuery selector and styles since they won't return any object.

behatnotneeded

Change-Id: Ia981e2c2599b4fb1ca6ade48bd376cca0cebbc85
(cherry picked from commit 2a20af65e1a2d175bfca49de5e7a020f7755df6f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891939

Title:
  Instituion static page edit not disabled

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Should not allow to edit an institution static page while the 'Use
  site default' is set to yes

  To test
  - Have an institution
  - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes

  expected result: the tinyMCE editor is greyed out and you are not allowed to make changes
  actual result: the tinyMCE editor is enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891939/+subscriptions


References