← Back to team overview

mahara-contributors team mailing list archive

[Bug 1891554] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11143
Committed: https://git.mahara.org/mahara/mahara/commit/f9d470152bd5babc167893e6997fb61bcfa243f0
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit f9d470152bd5babc167893e6997fb61bcfa243f0
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 14 18:01:02 2020 +1200

Bug 1891554: fixing up how bargraphs ordering work

Need to fetch actual top ten and not the first ten
Also need to set the axis to start at 0

Change-Id: Iacd1cc527a29ffc0e1dfa1157285b3e5ba073b48
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891554

Title:
  Code to generate charjs bar graph is not correct

Status in Mahara:
  Fix Committed

Bug description:
  The code in get_bar_graph_json() was not generating a bar graph
  correctly.

  Also made the option 'showlegendcallback' so we can turn off the
  legend when we don't need it

  Also made the Admin -> Report -> site overview page 'Most frequently
  used blocks in portfolio pages' list change from a list of top five to
  a horizontal bar graph of the top 10

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891554/+subscriptions


References