← Back to team overview

mahara-contributors team mailing list archive

[Bug 1892105] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11181
Committed: https://git.mahara.org/mahara/mahara/commit/bc5e6564b56b79b40b7173699ea233fc50ba14c6
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit bc5e6564b56b79b40b7173699ea233fc50ba14c6
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Tue Aug 25 18:19:43 2020 +1200

Bug 1892105: use correct cover image when copying collection

If a collection and its copy have the same owner,
then use the same artefact id (same image file)
as the cover image.

If the owners are different then use the copied
file artefact id for the cover image

behatnotneeded

Change-Id: Iab1e3168925ce567934b34b73627832035b809a8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892105

Title:
  Cover image file not copied for institution collection

Status in Mahara:
  Fix Committed

Bug description:
  When you have a collection on the institution level and add a cover
  image, the file is not associated when you copy it into your personal
  account. The file still comes along, but is not placed into the 'Cover
  images' folder.

  It nearly works fine for pages (see note below).

  This also needs to be tested for copying of collections on all other
  levels (personal, site, group).

  To replicate for institution collection:

  1. As site or institution admin, create a collection with 1 page.
  2. Upload a cover image to the collection.
  3. Share the page and make it copyable.
  4. Log in as another account holder.
  5. Copy the collection.
  6. View the collection on 'Pages and collections'.
  Expected result: The collection's cover image is displayed.
  Actual result: There is not cover image displayed.

  **Please note: When the above steps are 'repeated' for a page, the
  page cover image does display on the 'Pages and collections' page,
  however, the file is NOT present in the 'Files' > 'Cover images'
  folder.  It is instead placed in a sub-folder of the 'viewfiles'
  folder, this sub-sub-folder also contains any other files that were
  present for the copied page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892105/+subscriptions


References