mahara-contributors team mailing list archive

[Mahara Bot <1892790@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/11177
Committed: https://git.mahara.org/mahara/mahara/commit/2c46d657df3487de3636992b716e7b5a36e477c5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 2c46d657df3487de3636992b716e7b5a36e477c5
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Aug 25 10:59:25 2020 +1200

Bug 1892790: Google Apps Block unable to parse URL to google drive
folder

- added new pattern to match drive.google.com/folders

Change-Id: I0df15ec721eb88fadc1d9ae7ffa5cdef6313171b
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892790

Title:
  Google Apps Block unable to parse URL to google drive folder

Status in Mahara:
  In Progress

Bug description:
  Google Drive URLs aren't parsed correctly any more and don't display
  the Google Drive folder icon (or whatever needs to be displayed).

  For example, the folder https://drive.google.com/drive/folders/0B-V_s
  ... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
  MyPortfolio (and also master) it only displays:

  "Unable to parse embedded code or URL:
  https://drive.google.com/drive/folders/0B-V_s ...
  0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

  To replicate:
  1. Log in and create a page and select to create a "Google Apps" block
  2. In the "Embed code or URL" put the above url and save the block.
  Expected results:
  The block displays with icon etc... correctly
  Actual results:
  The block displays with "Unable to parse embedded code or URL: https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy "

  Our regex is failing to parse this pattern and we'll need to add to it
  while keeping any necessary previous patterns for backwards
  compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892790/+subscriptions