← Back to team overview

mahara-contributors team mailing list archive

[Bug 1893607] A change has been merged

 

Reviewed:  https://reviews.mahara.org/11200
Committed: https://git.mahara.org/mahara/mahara/commit/f2196d735e9988a951d546eefb918edcf1f42e6e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f2196d735e9988a951d546eefb918edcf1f42e6e
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Sep 1 12:20:18 2020 +1200

Bug 1893607: Admin reports that list pages should only have links if
admin can view page

- add check to see if USER can view portfolio to conditionally display URL
- add check for item pending to conditionally display pending text
- alter formatting of template for readability
- remove pending styling for entire column (needed to have $item->pending != null to work
so wasn't working already, and if displayed, requires further styling to have accesible contrast

Change-Id: Ice988ab891c8369e2bc4b323b3a0316f7989aae5
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893607

Title:
  Admin reports that list pages should only have links if admin can view
  page

Status in Mahara:
  Fix Committed

Bug description:
  In some of the admin reports there are pages / collections listed as
  links to the referenced page.

  But admins might not have access to the page (without masquerading) so
  we should only show the links for the pages they have access to (or
  force them to masquerade maybe)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893607/+subscriptions


References